Project

General

Profile

Actions

ClientProject #3221

open

SQA bug fix from sprint 3

Added by Nazmul Hossain Shovon 7 months ago. Updated 6 months ago.

Status:
Complete
Priority:
High
Target version:
Start date:
09/12/2025
Due date:
09/15/2025 (about 7 months late)
% Done:

100%

Estimated time:
10:00 h
Spent time:

Description

Changes Overview

  1. Contact Form Enhancements
    Description : Improved validation for the contact form in EnquireModal using stricter Zod schemas for fields (name, city, port, country, mobile, message). Added a loading spinner component for port loading feedback. Removed Viber contact option from header data.
    Testing Instructions:
  • Open the EnquireModal (e.g., via a "Contact Us" or "Enquire" button).
  • Test form validation by submitting with invalid inputs (e.g., empty name, invalid mobile number, or missing required fields). Verify error messages display clearly.
  • Check that a loading spinner appears when selecting a port.
  • Confirm the Viber contact option is no longer present in the header.
  1. Filter Component Improvements
    Description : Enhanced filter functionality by disabling search/reset buttons and showing error messages when min values exceed max for price, mileage, or engine CC. Standardized font sizes (text-xs md:text-sm) for filter labels and inputs. Added a loading spinner for model loading in FilterOptions.tsx. Introduced showCount prop to FilterCombobox for flexible count display.
    Testing Instructions:
  • Navigate to the filter section (e.g., vehicle search page).
  • Test invalid filter inputs (e.g., set min price higher than max price) and verify error messages appear and buttons are disabled.
  • Check that font sizes for filter labels and inputs are consistent across mobile and desktop views.
  • Select a model in the filter and confirm a loading spinner appears during model loading.
  • Verify the showCount prop in FilterCombobox displays or hides counts as expected.
  1. Number Formatting with prettyNumber Utility
    Description : Updated the prettyNumber utility for robust number formatting and applied it to filter/model counts and all price displays across product components and filters for consistent thousand separators.
    Testing Instructions:
  • Check price displays in product listings, filters, and sidebars to ensure consistent formatting with thousand separators (e.g., 1,000,000 instead of 1000000).
  • Verify filter and model counts in the sidebar and filter components use the same formatting.
  1. Header and Footer Updates
    Description : Added a staticPages array in header.ts and rendered these links in the header's top section. Refactored header links and submenu items for clarity. Hid the footer's TopSection component (commented out).
    Testing Instructions:
  • Verify new static page links appear in the header's top section and navigate correctly.
  • Check that header links and submenus are organized clearly and function as expected.
  • Confirm the footer's TopSection is not visible on any page.
  1. Download API and Button Enhancements
    Description : Updated the download API endpoint in DownloadButton.tsx and adjusted the download logic in the API route.
    Testing Instructions:
  • Locate a DownloadButton (e.g., on a product or resource page).
  • Click the button and verify the file downloads correctly via the updated API endpoint.
  • Test edge cases (e.g., no file available) to ensure proper error handling.
  1. UI/UX and Accessibility Improvements
    Description : Updated UI text (e.g., "Specification" to "SPECIFICATIONS"). Adjusted spacing, button sizes, and placeholder text in filter components. Added explicit elements to required fields in EnquireModal for better accessibility. Applied minor tweaks to car details and specifications components for font weight and layout consistency.
    Testing Instructions:
  • Verify text changes (e.g., "SPECIFICATIONS" in car details or relevant sections).
  • Check filter components for consistent spacing, button sizes, and placeholder text.
  • Test EnquireModal with a screen reader to confirm required fields are properly marked and accessible.
  • Inspect car details and specifications components for consistent font weights and layout.
  1. Code Cleanup and Minor Tweaks
    Description : Performed minor code cleanup and UI/UX tweaks for improved maintainability and user experience.
    Testing Instructions:
  • Review code changes in the commit for cleanliness and adherence to project standards.
  • Test affected components (e.g., filters, modals) to ensure no regressions in functionality or UI.
Actions #1

Updated by Nazmul Hossain Shovon 7 months ago

  • Target version changed from Revamp.v1.1: sprint 01 to Revamp.v1.1: sprint 04
Actions #2

Updated by Nazmul Hossain Shovon 7 months ago

  • % Done changed from 0 to 60

ref:
https://github.com/pqsjapan/frontendV1.1/commit/142028add10c2becb80d9c19acf944cd6b07c179

Short Summary of Key Changes:

  • Enhanced validation for contact form fields (name, city, port, country, mobile, message) using stricter Zod schemas.
  • Added a loading spinner component and integrated it into the EnquireModal for port loading feedback.
  • Improved filter options: now disables search/reset buttons and shows error messages if min values exceed max for price, mileage, or engine CC.
  • Updated some UI text (e.g., "Specification" to "SPECIFICATIONS").
  • Removed Viber contact option from header data.
  • Minor UI/UX tweaks and code cleanup.
Actions #3

Updated by Nazmul Hossain Shovon 7 months ago

  • % Done changed from 60 to 80

ref:
https://github.com/pqsjapan/frontendV1.1/commit/97a1eff39d3ae3d8c32d5844a3a3dd92f3771759

Short Summary of Key Changes:

  • Standardized font sizes to use text-xs md:text-sm for filter labels and inputs for better consistency across devices.
  • Updated prettyNumber utility for more robust number formatting and applied it to filter/model counts in sidebar and filter components.
  • Improved UI/UX in filter components: adjusted spacing, button sizes, and placeholder text.
  • Hid the footer's TopSection component (commented out).
  • Minor tweaks to car details and specifications components for font weight and layout consistency.
  • Added showCount prop to FilterCombobox for flexible count display.
Actions #4

Updated by Nazmul Hossain Shovon 7 months ago

  • % Done changed from 80 to 90

ref:
https://github.com/pqsjapan/frontendV1.1/commit/2da34751c2dab64f8f059704d489663db2e903f3

Summary of Key Changes:

  • Added a new staticPages array in header.ts and rendered these links in the header's top section.
  • Updated the download API endpoint in DownloadButton.tsx and adjusted the download logic in the API route.
  • Improved the model filter UI by showing a loading spinner when models are loading in FilterOptions.tsx.
  • Refactored and reorganized header links and submenu items for clarity and consistency.
Actions #5

Updated by Nazmul Hossain Shovon 7 months ago

ref:
https://github.com/pqsjapan/frontendV1.1/commit/f36f218569b841c2ae8587ff65130b6fb6fbaa39

Short Summary of Key Changes:

  • Applied prettyNumber formatting to all price displays for better readability across product components and filters.
  • Added explicit elements to all required fields in the EnquireModal for improved accessibility and clarity.
  • Enhanced filter and sidebar components to consistently format and display price values with thousand separators.
Actions #6

Updated by Nazmul Hossain Shovon 7 months ago

  • Description updated (diff)
Actions #7

Updated by Nazmul Hossain Shovon 6 months ago

  • Status changed from In Progress to Complete
  • % Done changed from 90 to 100
Actions

Also available in: Atom PDF